Taylor Blau's patch addresses a problem in the skipping negotiator. Its queue is sorted by commit date, but push_parent() can add a parent before it is parsed. The parent's date is still zero, so old ref tips sort ahead of it. With enough old refs, negotiation can end before a recent common ancestor is offered. The patch parses each unseen parent before queueing and leaves out any parent that fails to parse.

Blau first kept the parse in push_parent(). She then reconsidered, noting that the default negotiator's rev_list_push() parses the commit itself. She agreed that putting the parse in the skipping negotiator's rev_list_push() is better for ergonomics and consistency. Only push_parent() needs to handle a NULL return, since the other two callers already ignore the return value. She said she moved it there for the next round.

Junio C Hamano noted a hazard with that design. If rev_list_push() marks a commit SEEN and then fails to parse it, a later encounter finds it SEEN, looks for it in the priority queue and triggers BUG("missing parent in priority queue"). He suggested marking the commit SEEN only after repo_parse_commit() succeeds. He noted this only arises with a corrupt repository.

On the test, Hamano said it looked good enough. He tried to avoid a pipe in the test script but the best alternative he found was a dense sed expression he called not exactly readable.

What remains is the next revision and whether it handles the unparsable-commit ordering.