git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: nd/setup

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Apr 3, 2010, 14:39 UTC
Message-ID
<z2gfcaeb9bf1004030739q9575b629p44c4461e90c37d40@mail.gmail.com>
In-Reply-To
<20100403050057.GA20525@progeny.tock>
On Sat, Apr 3, 2010 at 7:00 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 6 quoted lines
> Nguyen Thai Ngoc Duy wrote:
>
>> I haven't forgotten the "git init" with alias bug Jonathan found. Just
>> a little busy with other stuff.
>
> You already fixed it, I think. ;-)
Hmm.. so I do forget something. I still miss some of your good tests though.
Show 25 quoted lines
> -- %< --
> Subject: Revert "help: use RUN_SETUP_GENTLY"
>
> Commit 717b8850580ecb9009505f71ea43ecda51ac1f0e taught ‘git help’
> to unconditionally looks for a git directory, with the justification:
>
>    So the sooner we set up gitdir, the less trouble we may have to
>    deal with.
>
> In the case of ‘git help -a’, that is not quite true.  In automount
> setups like that which prompted v1.6.0-rc0~121^2~1 (Add support for
> GIT_CEILING_DIRECTORIES, 2008-05-19), if GIT_CEILING_DIRECTORIES is
> unset, then probing for the Git directory can take a long time.  Thus
> unnecessarily searching for a git directory can slow down ‘git help -a’
> (and thus bash completion).
>
> ‘git help’ does not use RUN_SETUP or USE_PAGER, and neither option
> parsing nor producing output for plain ‘git help’ or ‘git help -a’
> requires access to the git configuration.  Therefore it is safe to not
> search for the git directory early in this case.
>
> Also add some comments to document the requirements this places on
> list_commands() and list_common_cmds_help().
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>

Didn't notice it. Looks good. I will replace the "help: use RUN_SETUP_GENTLY" commit with this patch next time, if you don't mind.

-- 
Duy
Previous: Jonathan NiederNext: Nguyen Thai Ngoc Duy
Message 4 of 8 in “What's cooking in git.git (Apr 2010, #01; Fri, 02)”
  1. Junio C HamanoApr 2, 2010
  2. Nguyen Thai Ngoc DuyApr 2, 2010
  3. nd/setupJonathan Nieder, Apr 3, 2010
  4. Nguyen Thai Ngoc DuyApr 3, 2010
  5. Nguyen Thai Ngoc DuyApr 4, 2010
  6. Junio C HamanoApr 4, 2010
  7. Sverre RabbelierApr 2, 2010
  8. Nicolas PitreApr 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.