Re: [PATCH 2/2] receive-pack: ignore duplicated commands which can occur with symrefs
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Apr 15, 2010, 23:07 UTC
- Message-ID
- <y2g76718491004151607u58021df8naab23b6daf06513d@mail.gmail.com>
- In-Reply-To
- <7v39ywiat9.fsf@alter.siamese.dyndns.org>
On Thu, Apr 15, 2010 at 6:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> Jay Soffian <jaysoffian@gmail.com> writes: > >> When pushing to a remote repo, normally the sending side tries to >> filter out any aliased updates (e.g, foo:baz bar:baz). However, it >> is impossible for the sender to know if two refs are aliased on the >> receiving side via symrefs. Here is one such scenario: >>
> [... lots of good feedback ...]
Will incorporate and re-roll.
Show 7 quoted lines
> This will also catch two symrefs that point at the same underlying ref. > If all three are updated consistently then all will be fine. If even one > of them is inconsistent, we will try the update() and give an error > message. > > We _could_ give even stronger error message to help diagnosing the > situation if we wanted to.
Okay, I'll see what I can figure out.
> Very nice.
I appreciate the compliment, but it is unexpected after reading your reply to "failed to lock". I think your suggestion there (fix verify_lock()) probably addresses the real problem in which case this is just a band-aid.
j.