Re: [PATCH 1/2] clone: add disassociate alias to dissociate option

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 21, 2015, 07:13 UTC
Message-ID: <xmqqzj87wxck.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150221062754.GC29665@peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Fri, Feb 20, 2015 at 11:10:22AM -0800, Matt Whiteley wrote:
>
>> diff --git a/builtin/clone.c b/builtin/clone.c
>> index 316c75d..7e193ae 100644
>> --- a/builtin/clone.c
>> +++ b/builtin/clone.c
>> @@ -97,6 +97,8 @@ static struct option builtin_clone_options[] = {
>>  		    N_("clone only one branch, HEAD or --branch")),
>>  	OPT_BOOL(0, "dissociate", &option_dissociate,
>>  		 N_("use --reference only while cloning")),
>> +	OPT_BOOL(0, "disassociate", &option_dissociate,
>> +		 N_("use --reference only while cloning")),
>
> Should this second one be marked as OPT_HIDDEN? I do not think we need
> to show both in "git clone --help".

For that matter, I am not sure why we want to add this synonym in the first place.

http://www.merriam-webster.com/dictionary/dissociate

    : to end your relationship with or connection to someone or
    something : to separate (yourself) from someone or something

which is exactly what I wanted the option to achieve.