git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC][GSoC] make "git diff --no-index $directory $file" DWIM better.

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 15, 2015, 22:00 UTC
Message-ID
<xmqqzj7dsyyn.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAPig+cRFCktpG2ksNnRZiFxDqmQnq38MafkA1E-LC6CHtcuk9g@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
>>> Is this name supposed to stand for "dir'n'file",...
> ...I personally find the idiomatic name 'path'
> easier to grok, however, Junio, of course, has final say-so.

If I were presented two identical patches, one calling it "path" and the other calling it "dirnfile", I would definitely take the former, but I agree that this is more of a preference than a taste, the latter of which implies that you could make a value judgement, i.e. "good taste" vs "bad taste".

If for some reason we had a code that called a variable "dirnfile" already in our official codebase and we saw a patch to "correct" that to "path", I would likely say that it is not worth the churn to apply such a "correction" patch. If the new name were "pathname", however, I might be pursuaded to take it, simply because a "pathname" is a lot more familiar word than "dirnfile".

Previous: Eric Sunshine
Message 13 of 13 in “[GSoC] make "git diff --no-index $directory $file" DWIM better.”
  1. [GSoC] make "git diff --no-index $directory $file" DWIM better.Yurii Shevtsov, Mar 15, 2015
  2. Matthieu MoyMar 15, 2015
  3. Junio C HamanoMar 16, 2015
  4. Yurii ShevtsovMar 16, 2015
  5. Junio C HamanoMar 16, 2015
  6. Yurii ShevtsovMar 16, 2015
  7. Junio C HamanoMar 16, 2015
  8. t.gummerer@gmail.comMar 15, 2015
  9. Eric SunshineMar 15, 2015
  10. Junio C HamanoMar 15, 2015
  11. t.gummerer@gmail.comMar 15, 2015
  12. Eric SunshineMar 15, 2015
  13. Junio C HamanoMar 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.