Re: [PATCH 0/2] git-p4: support python3 in the tests

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2016, 22:07 UTC
Message-ID: <xmqqzishibpz.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1461420826-4416-1-git-send-email-luke@diamand.org>

Luke Diamand <luke@diamand.org> writes:

Show 5 quoted lines

> This patchset updates the git-p4 tests so that they work with
> either Python2 or Python3.
>
> Note that this does *not* fix git-p4 to work with Python3 - that's
> a much bigger challenge.

We use Python outside p4 tests (e.g. remote-svn test), and the way they invoke the interpreter is to say "$PYTHON_PATH" and avoid saying "python" which picks whatever random version of Python interpreter happens to be the first on $PATH. Shouldn't the tests touched by this series be doing the same?

Show 8 quoted lines

>
> Luke Diamand (2):
>   git-p4 tests: cd to testdir before running python
>   git-p4 tests: work with python3 as well as python2
>
>  t/lib-git-p4.sh            | 7 ++++---
>  t/t9802-git-p4-filetype.sh | 6 +++---
>  2 files changed, 7 insertions(+), 6 deletions(-)