Re: [PATCH 4/6] RelNotes: mention that PCRE v2 exposes the same syntax

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 20, 2017, 15:24 UTC
Message-ID: <xmqqzibzku6m.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170720141927.18274-5-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> For someone not familiar with PCRE or having read its own
> documentation this isn't obvious, let's explicitly mention it so
> package maintainers won't fear upgrading least they break things for
> their users.

If packagers trust our assessment on one external library's backward compatibility, our using and recommending it is sufficient to them. If the don't trust us but rather want to verify themselves, the new paragraph is not all that useful to them, and more importantly, we are not in the position or business of giving extended warranty to other people's library.

For these reasons, I'd feel a bit hesitant to add something like this.

Show 20 quoted lines

>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  Documentation/RelNotes/2.14.0.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt
> index 7ed93bca37..0e363f2af3 100644
> --- a/Documentation/RelNotes/2.14.0.txt
> +++ b/Documentation/RelNotes/2.14.0.txt
> @@ -28,6 +28,9 @@ Backward compatibility notes and other notable changes.
>     upstream PCRE maintainer has abandoned v1 maintenance for all but
>     the most critical bug fixes, use of v2 is recommended.
>  
> +   Version v2 of the library is fully backwards compatible with the
> +   Perl-compatible regular expression syntax exposed by git (sans a
> +   few obscure bugfixes).
>  
>  Updates since v2.13
>  -------------------