git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] branch doc: remove --set-upstream from synopsis

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 17, 2017, 01:18 UTC
Message-ID
<xmqqzi7lu2h8.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171116074643.19614-1-tmz@pobox.com>
Todd Zullinger <tmz@pobox.com> writes:
Show 10 quoted lines
> Support for the --set-upstream option was removed in 52668846ea
> (builtin/branch: stop supporting the "--set-upstream" option,
> 2017-08-17), after a long deprecation period.
>
> Remove the option from the command synopsis for consistency.  Replace
> another reference to it in the description of `--delete` with
> `--set-upstream-to`.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---

Makes sense. Even though we internally still carry (and have to carry) code to notice and explicitly reject "--set-upstream", I do not think that we need to suggest its presence to the end user.

The option parsing code marks it with the PARSE_OPT_HIDDEN bit correctly and it would make sense to make the synopsis section follow suit.

Thanks.
Previous: Todd ZullingerNext: Todd Zullinger
Message 5 of 7 in “branch doc: remove --set-upstream from synopsis”
  1. branch doc: remove --set-upstream from synopsisTodd Zullinger, Nov 16, 2017
  2. Martin ÅgrenNov 16, 2017
  3. Kaartic SivaraamNov 16, 2017
  4. Todd ZullingerNov 16, 2017
  5. Junio C HamanoNov 17, 2017
  6. Todd ZullingerNov 17, 2017
  7. Junio C HamanoNov 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.