git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config: move flockfile() closer to unlocked functions

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 30, 2018, 19:52 UTC
Message-ID
<xmqqzi2p1gus.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180330192615.GB32338@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 16 quoted lines
> On Fri, Mar 30, 2018 at 09:04:13PM +0200, Johannes Schindelin wrote:
>
>> > Probably the flockfile should go into do_config_from_file(), where we
>> > specify to use the unlocked variants.
>> 
>> Ah, that makes sense now! I am glad I could also help ;-)
>
> :)
>
>> > Yeah, I'll wait to see how your refactor turns out.
>> 
>> I don't think I'll touch too much in that part of the code. My changes
>> should not cause merge conflicts with a patch moving the
>> flockfile()/funlockfile() calls to do_config_from_file().
>
> OK, then let's do this while we're thinking about it:

Yup, what Dscho found was quite amusing ;-) and this obviously makes the code clearer to follow.

Will queue, thanks.
Previous: Jeff King
Message 2 of 2 in “config: move flockfile() closer to unlocked functions”
  1. config: move flockfile() closer to unlocked functionsJeff King, Mar 30, 2018
  2. Junio C HamanoMar 30, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.