Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 14, 2018, 16:20 UTC
Message-ID: <xmqqzhwkcaph.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <0a3baaf6-f71b-e8f9-7445-8bf2b5d3513e@gmail.com>

Ben Peart <peartben@gmail.com> writes:

Show 10 quoted lines

>> I think it is OK to make it error only if the old one is set without
>> the new one.  Then people can have _both_ set to the same value
>> during the period in which the topic sails through pu down to next
>> down to master, after seeing an failure once while building and
>> testing 'pu'.
>>
>
> I'll make it a warning if they are both set so that people are
> reminded to remove the old variable and an error if only the old one
> is set so people know to update their environment.

After the topic graduates to a stable release (or two), it would be a good addition to encourage people to clean things up, of course, but doing so too early by warning when they are both set is not a good idea, I would think. It would bring us back to "the user has to futz with config.mak every time switching between 'maint' and 'next'".

> I'll combine all these into a single patch series.  It grew as I
> discovered more that needed to be updated.

Thanks.

 I didn't mind it too much to have them as independent patches.  It
at least helped me forcing myself to give closer look at them ;-)