Re: [PATCH v2 3/3] rebase (autostash): use an explicit OID to apply the stash

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 23, 2018, 04:13 UTC
Message-ID: <xmqqzhv5s3lf.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181022223256.GI30222@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

>> To prevent that from happening, let's append `^0` after the stash hash,
>> to make sure that it is interpreted as an OID rather than as a number.
>
> Oh, this is clever.

Yeah, we can do this as we know we'd be dealing with a commit-ish. If we made a mistake to use a tree object to represent a stash, this trick wouldn't have been possible ;-)

Show 5 quoted lines

> FWIW, all patches look good to me, barring the typo below.
> ...
>> +	/* Ensure that the hash is not mistake for a number */
>
> s/mistake/mistaken/

Will squash this in and add your reviewed-by before queuing.

Thanks, both.