git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Bug report] git diff stat shows unrelated diff

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 15, 2019, 20:12 UTC
Message-ID
<xmqqzhqw4xqe.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CABPp-BEmPQb4Q_38S2A_68m+Cu75VDDD2UV0qWBDjL1OUAug9Q@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 11 quoted lines
>> Instead of outright deprecating it, would it make sense to include a
>> configuration option, say "diff.sensibleDots", that would enable a user
>> to set the dots to the other form if they desire?
>
> I think Junio's suggested steps would still have to come first, and
> there may also need to be a time period after two-dot notation is an
> error before we were to try to repurpose it for something else (e.g.
> to make it behave the same as triple-dot).  Adding a config to change
> things now without both a deprecation and error period would invite
> horrible surprises and bug reports; people need time and warning to
> change workflows and fix existing scripts that might be out there.

Historically, it was a mistake to allow A..B to be used for two endpoints, which was made back when we haven't thought things through. That is why I stopped "warn to deprecate and then completely remove", as I do not think it would help people very much if "git diff A B" can be spelled with two-dots.

But in a distant future long after that happens, by the time nobody remembers what A..B meant for "git diff", I do not think I'd strongly be opposed to reusing it to mean something different.

Previous: Elijah NewrenNext: Philip Oakley
Message 7 of 17 in “[Bug report] git diff stat shows unrelated diff”
  1. Viresh KumarFeb 14, 2019
  2. Johannes SixtFeb 14, 2019
  3. Elijah NewrenFeb 14, 2019
  4. Junio C HamanoFeb 14, 2019
  5. Denton LiuFeb 15, 2019
  6. Elijah NewrenFeb 15, 2019
  7. Junio C HamanoFeb 15, 2019
  8. Philip OakleyFeb 15, 2019
  9. Junio C HamanoFeb 15, 2019
  10. Philip OakleyFeb 16, 2019
  11. Junio C HamanoFeb 17, 2019
  12. Philip OakleyFeb 17, 2019
  13. Junio C HamanoFeb 18, 2019
  14. Junio C HamanoFeb 15, 2019
  15. Viresh KumarFeb 15, 2019
  16. Elijah NewrenFeb 15, 2019
  17. Viresh KumarFeb 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.