git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 18, 2019, 05:23 UTC
Message-ID
<xmqqzhps4uyq.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CAPig+cRMiEcXVRYrgp+B3tcDreh41-a5_k0zABe+HNce0G=Cyw@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
> So, I'm fairly negative on this change. However, that doesn't mean I
> would oppose tweaking the value shared between the two programs (and
> also the default used by GitGitGadget, if it specifies it manually),
> though I defer to Dscho in that regard.

I do not think of a good reason why the command should behave differently only when run from inside format-patch, and if we were changing anything, perhaps raising it a bit for all may make sense. I have yet to see range-diff getting confused and matching wrong patches but often seee it being too conservative to match two iterations of the same patch after a moderate amount of update.

I find myself passing "--creation-factor 99" or some absurdly looking value when accepting a rerolled series. The most recent was the updated 'clean-up merge message with scissors' from Denton [*1*].

[Footnote]

*1* <6716d28a5187c44c1d90f5ce840c44441f62352c.1552275703.git.liu.denton@gmail.com> and <08426189b5a29b376581eb0172e52222ab22387a.1552817044.git.liu.denton@gmail.com> do not line up without a high creation factor.

Previous: Johannes Schindelin
Message 5 of 5 in “Use a higher range-diff --creation-factor for format-patch”
  1. Use a higher range-diff --creation-factor for format-patchÆvar Arnfjörð Bjarmason, Mar 15, 2019
  2. Eric SunshineMar 15, 2019
  3. Ævar Arnfjörð BjarmasonMar 15, 2019
  4. Johannes SchindelinMar 21, 2019
  5. Junio C HamanoMar 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.