git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ds/sparse-cone, was Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 15, 2019, 03:20 UTC
Message-ID
<xmqqzhi2bsp8.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20191015015052.GA19636@dcvr>
Eric Wong <e@80x24.org> writes:
Show 6 quoted lines
> I just took a brief look, but that appears to leak memory.
>
> "hashmap_free(var, 1)" should be replaced with
> "hashmap_free_entries(var, struct foo, member)"
>
> Only "hashmap_free(var, 0)" can become "hashmap_free(var)"

I deliberately avoided merge-time band-aid fixups on this topic and ew/hashmap exactly because I was sure that I'd introduce a similar bugs by doing so myself. Using evil merges can be a great way to help multiple topics polished independently at the same time, but when overused, can hide this kind of gotchas quite easily.

A reroll on top of ew/hashmap would be desirable, now that topic is ready for 'master'.

Thanks.
Previous: Eric WongNext: Eric Wong
Message 9 of 12 in “What's cooking in git.git (Oct 2019, #03; Fri, 11)”
  1. Junio C HamanoOct 11, 2019
  2. Elijah NewrenOct 11, 2019
  3. Junio C HamanoOct 11, 2019
  4. Elijah NewrenOct 11, 2019
  5. Junio C HamanoOct 11, 2019
  6. Junio C HamanoOct 12, 2019
  7. ds/sparse-cone, was Re: What's cooking in git.git (Oct 2019, #03; Fri, 11)Johannes Schindelin, Oct 12, 2019
  8. Eric WongOct 15, 2019
  9. Junio C HamanoOct 15, 2019
  10. Eric WongOct 15, 2019
  11. Derrick StoleeOct 15, 2019
  12. Junio C HamanoOct 16, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.