git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file"

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 20, 2020, 18:08 UTC
Message-ID
<xmqqzhcac313.fsf@gitster.c.googlers.com>
In-Reply-To
<20200320160723.15190-1-adrianwijaya100@gmail.com>
Adrian Wijaya <adrianwijaya100@gmail.com> writes:
>  	test "z$(git config --file=notyet test.frotz)" = znitfol &&

We see 130+ instances of this rather antiquated construct that presumably avoids to compare an empty string with something else using "test X = Y" tool. It might have been a good idea in 2005 (I do not remember why we started doing this), but perhaps it is time to clean them up by listing it as another microproject idea for the next year?

Previous: Junio C Hamano
Message 8 of 8 in “t1300: replace "test -f" into "test_path_is_file"”
  1. Adrian WijayaMar 19, 2020
  2. [GSOC][PATCH 2/2] t1300: replace "test -f" into "test_path_is_file"Adrian Wijaya, Mar 19, 2020
  3. Jeff KingMar 20, 2020
  4. adrian wijayaMar 20, 2020
  5. adrian wijayaMar 20, 2020
  6. [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file"Adrian Wijaya, Mar 20, 2020
  7. Junio C HamanoMar 20, 2020
  8. Junio C HamanoMar 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.