Re: [PATCH 1/2] test-lib-functions: make packetize() more efficient

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2020, 15:44 UTC
Message-ID: <xmqqzhbzb1xt.fsf@gitster.c.googlers.com>
In-Reply-To: <20200329145343.GB15400@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> On Sat, Mar 28, 2020 at 08:05:10PM -0700, Junio C Hamano wrote:
>
>> -- >8 --
>> Subject: CodingGuidelines: allow ${#posix} == strlen($posix)
>
> I'm in favor of this patch, but...
>
>> The construct has been in POSIX for the past 10+ years, and we have
>> used in t9xxx (subversion) series of the tests, so we know it is at
>> least portable across systems that subversion Perl bindings have
>> been ported to.
>
> It is even stronger than that. t9010 is run for everybody (with the
> exception of the last test, which needs svnadmin).

Ah, you're right.  Lemme make it stronger.

    The construct has been in POSIX for the past 10+ years, and we have
    used in t9xxx (subversion) series of the tests, so we know it is at
    portable across systems that people have run those tests, which is
    almost everything we'd care about.

Thanks.