Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2020, 05:35 UTC
Message-ID: <xmqqzhb8rqa6.fsf@gitster.c.googlers.com>
In-Reply-To: <6bf94982-71c4-78e9-0f4d-7fa4e485c417@blastwave.org>

Dennis Clarke <dclarke@blastwave.org> writes:

> Very minor patch required :

But both size_t and unsigned int are wrong types, no? Shouldn't we be using socklen_t (and we seem to have autoconf support to figure out an appropriate socklen_t fallback typedef)?

Show 31 quoted lines

> --- ./compat/inet_ntop.c.orig   Tue Apr 14 01:51:03 2020
> +++ ./compat/inet_ntop.c        Sun Apr 19 04:16:39 2020
> @@ -168,7 +168,7 @@
>   *     Paul Vixie, 1996.
>   */
>  const char *
> -inet_ntop(int af, const void *src, char *dst, size_t size)
> +inet_ntop(int af, const void *src, char *dst, unsigned int size)
>  {
>         switch (af) {
>         case AF_INET:
> --- ./git-compat-util.h.orig    Tue Apr 14 01:51:03 2020
> +++ ./git-compat-util.h Sun Apr 19 03:56:17 2020
> @@ -795,7 +795,7 @@
>  #endif
>
>  #ifdef NO_INET_NTOP
> -const char *inet_ntop(int af, const void *src, char *dst, size_t size);
> +const char *inet_ntop(int af, const void *src, char *dst, unsigned
> int size);
>  #endif
>
>  #ifdef NO_PTHREADS
> #
> # exit
>
> That allows compile to proceed beatly with :
>
> alpha$
> alpha$ cc -V
> cc: Studio 12.6 Sun C 5.15 SunOS_sparc 2017/05/30