git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 0/1] Leading whitespace as a function identification heuristic?

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 24, 2020, 06:45 UTC
Message-ID
<xmqqzh5fhduk.fsf@gitster.c.googlers.com>
In-Reply-To
<20200923215859.102981-1-rtzoeller@rtzoeller.com>
Ryan Zoeller <rtzoeller@rtzoeller.com> writes:
> 1. Is this indentation-aware function identification useful, and
>     generally worth pursuing further?

I cannot shake the feeling off that this is being overly generous and inviting for misidentification for languages whose usual convention is not to nest and indent the definitions freely.

IOW, why can't the "we allow leading whitespaces" a per-language thing? IOW, why do we even need any new code---shouldn't it be just the matter of defining xfuncname patterns for such a language with nested and indented definitions?

So, a mild Meh from me at this point. I may change my mind in the morning, though ;-)

Thanks.
Previous: Ryan ZoellerNext: Jeff King
Message 3 of 10 in “[RFC 0/1] Leading whitespace as a function identification heuristic?”
  1. Ryan ZoellerSep 23, 2020
  2. 1/1 xdiff: use leading whitespace in function heuristicRyan Zoeller, Sep 23, 2020
  3. Junio C HamanoSep 24, 2020
  4. Jeff KingSep 24, 2020
  5. Ryan ZoellerSep 24, 2020
  6. Phillip WoodSep 25, 2020
  7. Jeff KingSep 25, 2020
  8. Phillip WoodSep 25, 2020
  9. Jeff KingSep 25, 2020
  10. Johannes SixtSep 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.