git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: BUG in fetching non-checked out submodule

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 3, 2020, 18:12 UTC
Message-ID
<xmqqzh2uhi6s.fsf@gitster.c.googlers.com>
In-Reply-To
<0b6a34a0-428e-5fc4-307d-1217b112659c@nokia.com>
Peter Kästle <peter.kaestle@nokia.com> writes:
Show 6 quoted lines
> On quick glance this sounds plausible, but to fully understand it I
> need to put some effort in reading this code again.  I hope to do so 
> tomorrow.  We can then compile a new set of patches including this
> real fix and Ralf's and my test case.
>
> Thanks for digging into it.

Yeah, thanks, both for noticing problem so quickly and started digging to find the real solution.

By the way, as to the "if this were originally two patches, we could have saved the test that expects failure" you raised, I do not think it is a good idea to optimize for cases where changes turn out problematic and have to get reverted.

Previous: Peter KästleNext: Peter Kaestle
Message 7 of 36 in “BUG in fetching non-checked out submodule”
  1. Ralf ThielowDec 2, 2020
  2. Philippe BlainDec 2, 2020
  3. Junio C HamanoDec 2, 2020
  4. Peter KästleDec 3, 2020
  5. Philippe BlainDec 3, 2020
  6. Peter KästleDec 3, 2020
  7. Junio C HamanoDec 3, 2020
  8. submodules: fix of regression on fetching of non-init subsub-repoPeter Kaestle, Dec 4, 2020
  9. Eric SunshineDec 4, 2020
  10. Peter KästleDec 7, 2020
  11. Eric SunshineDec 7, 2020
  12. submodules: fix of regression on fetching of non-init subsub-repoPeter Kaestle, Dec 7, 2020
  13. Philippe BlainDec 7, 2020
  14. Junio C HamanoDec 7, 2020
  15. Peter KästleDec 8, 2020
  16. Junio C HamanoDec 7, 2020
  17. Peter KästleDec 8, 2020
  18. Junio C HamanoDec 7, 2020
  19. Philippe BlainDec 7, 2020
  20. Junio C HamanoDec 7, 2020
  21. Junio C HamanoDec 7, 2020
  22. Peter KästleDec 8, 2020
  23. submodules: fix of regression on fetching of non-init subsub-repoPeter Kaestle, Dec 8, 2020
  24. Peter KästleDec 8, 2020
  25. Junio C HamanoDec 8, 2020
  26. Philippe BlainDec 8, 2020
  27. Peter KästleDec 9, 2020
  28. submodules: fix of regression on fetching of non-init subsub-repoPeter Kaestle, Dec 9, 2020
  29. Philippe BlainDec 9, 2020
  30. Ralf ThielowDec 3, 2020
  31. Peter KästleDec 3, 2020
  32. Ralf ThielowDec 3, 2020
  33. Peter KästleDec 3, 2020
  34. Ralf ThielowDec 3, 2020
  35. Peter KästleDec 3, 2020
  36. Ralf ThielowDec 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.