Re: [PATCH v2] usage: trace2 BUG() invocations

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 9, 2021, 21:18 UTC
Message-ID: <xmqqzh0dym71.fsf@gitster.c.googlers.com>
In-Reply-To: <20210209193459.3100734-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 12 quoted lines

>> > +# Verb 007bug
>> > +#
>> > +# Check that BUG writes to trace2
>> > +
>> > +test_expect_success 'normal stream, exit code 1' '
>> 
>> Is this description accurate? It doesn't really seem like "exit code 1".
>> Maybe "99", though BUG is probably more accurate.
>
> Ah...you're right. Maybe 'BUG messages are written to trace2' is better.
> If Junio doesn't do it locally (or if there are other issues that need
> fixing), I'll send out v3.

It will risk me forgetting and queueing v2 as-is, and would leave you nobody to blame.

Please do not assume that I am paying attention to each and every detail of discussions, especially the ones involving well known reviewers.