Re: [PATCH v3 3/6] mailinfo: warn if CR found in decoded base64/QP email
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 8, 2021, 10:52 UTC
- Message-ID
- <xmqqzgx5ts3z.fsf@gitster.g>
- In-Reply-To
- <5aac2ba38e5442019d2816c63d7b65bf2bcf062a.1620311544.git.congdanhqx@gmail.com>
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> +test_expect_success 'mailinfo warn CR in base64 encoded email' ' > + sed "s/%%/$(printf \\015)/" "$DATA/quoted-cr-msg" >expect-cr-msg && > + sed "s/%%/$(printf \\015)/" "$DATA/quoted-cr-patch" >expect-cr-patch &&
As we are not interested in a lone CR in the middle of the line, I wonder if we want to anchor the double per-cent to the end of the line, i.e. "s/%%$/$(printf \\015)/".
On the other hand, we may want to make sure that the new option does not disturb CR in the middle of the line, so we may be better off leaving double per-cent unanchored, but allow replacing more than once on a line, i.e. "s/%%/$(printf \\015)/g".
If we were to go to the latter route, we'd want to try a file with a CR in the middle of the line (without a CR at the end of any line) and make sure we won't warn or strip.