Re: [PATCH 2/9] test-mergesort: add sort subcommand

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 1, 2021, 20:26 UTC
Message-ID: <xmqqzgrs5w5r.fsf@gitster.g>
In-Reply-To: <f0a8c3c5-4c51-5128-42a3-3dadb8600a6f@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 19 quoted lines

> Give the code for sorting a text file its own sub-command.  This allows
> extending the helper, which we'll do in the following patches.
> ...
> -int cmd__mergesort(int argc, const char **argv)
> +static int sort_stdin(void)
>  {
>  	struct line *line, *p = NULL, *lines = NULL;
>  	struct strbuf sb = STRBUF_INIT;
> @@ -49,3 +49,10 @@ int cmd__mergesort(int argc, const char **argv)
>  	}
>  	return 0;
>  }
> +
> +int cmd__mergesort(int argc, const char **argv)
> +{
> +	if (argc == 2 && !strcmp(argv[1], "sort"))
> +		return sort_stdin();
> +	usage("test-tool mergesort sort");
> +}

This smelled funny, as it would certainly have broken any existing script in t/ that were using "test-tool mergesort <input".

But "git grep mergesort master -- t/" reveals that nobody uses it, so we are safe ;-)