Re: [PATCH v2 2/2] git-p4: show progress as an integer

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 20, 2021, 20:02 UTC
Message-ID: <xmqqzgovujs2.fsf@gitster.g>
In-Reply-To: <CAE5ih7_uq2xos46tH_dR+gietA_5bhr3JzYNJOLmrjhuijy1Ng@mail.gmail.com>

Luke Diamand <luke@diamand.org> writes:

Show 18 quoted lines

>> diff --git a/git-p4.py b/git-p4.py
>> index 4d8a249b85..3c621a6efd 100755
>> --- a/git-p4.py
>> +++ b/git-p4.py
>> @@ -3635,7 +3635,8 @@ def importChanges(self, changes, origin_revision=0):
>>              self.updateOptionDict(description)
>>
>>              if not self.silent:
>> -                sys.stdout.write("\rImporting revision %s (%s%%)" % (change, cnt * 100 / len(changes)))
>> +                sys.stdout.write("\rImporting revision %s (%d%%)" % (
>> +                    change, (cnt * 100) // len(changes)))
>>                  sys.stdout.flush()
>>              cnt = cnt + 1
>
> Thanks for fixing this - this is one of those small python2->python3
> bugs that's still left over.
>
> Looks good to me, ack.

Thanks. I'll wait for an updated [1/2] but this is an independently good change that does not depend on it, so I'll take [2/2] alone for now.