Re: [GSoC] Add –no-sort option for git-for-each-ref

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 1, 2022, 05:33 UTC
Message-ID: <xmqqzgnbf8w6.fsf@gitster.g>
In-Reply-To: <CAJyCBOTpmKCHaYEvNc1-r_Rs2OWMsyCO7P6iSeM78QcjjcPuHQ@mail.gmail.com>

Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> writes:

Show 8 quoted lines

> On Tue, Jan 25, 2022 at 5:59 PM Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> wrote:
>>
>> Hi git community,
>>
>> I'm considering if this microproject
>> [https://git.github.io/Outreachy-23-Microprojects/#add-no-sort-option-for-git-for-each-ref]
>>  is a good option for now. I want to spend some time on it and see if
>> I can come up with something.

I am fairly negative on that entry in the micro-project list (no, it is not your fault), because

 (1) the one that is described there is fairly useless and I do not
     think we want to take in my tree at all.

 (2) a variant that is any useful would be a bit too large for a
     micro-project

As the explanatory text there says, the code should be able to figure out when it does not need to make an extra ref_array_sort() call, without being told by the user.

A smaller and more appropriate "add --no-sort and when it is given, skip the call to ref_array_sort()" is much easier to do, but it is very much useless.

If we were to spend any project resources (both developer's time and reviewers' time), I'd rather not to see such an option added---once we add a feature, we'd have to maintain it. Rather, it would be much better use of our time to do "automatically figure out when we do not have to sort", and with that feature, nobody needs to use the "--no-sort" option at all.

Such an "automatically skip the call to ref_array_sort()" would be doable by a developer who may be relatively unfamiliar with our codebase, but is still a bit too large for a micro-project, which I expect anybody to be able to code during a lunch break and spend more time on review exchanges on the list.