Re: [PATCH v3 00/13] submodule: convert parts of 'update' to C

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2022, 21:41 UTC
Message-ID: <xmqqzgm690iu.fsf@gitster.g>
In-Reply-To: <220303.86sfrz5p9t.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 15 quoted lines

> On Wed, Mar 02 2022, Glen Choo wrote:
>
>> Original series: https://lore.kernel.org/git/20220210092833.55360-1-chooglen@google.com
>> (I've trimmed the cc list down to the 'most interested' parties)
>>
>> Thanks for the input, Ævar :) This just fixes up a few small issues in
>> the previous version.
>
> And thanks for working on this, there was a reason I was down to
> nitpicking in v2, this is looking really good & I can't find any issues
> with this iteration at all.
>
> So I'm happy to give this my:
>
> Reviewed-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Thanks for reviewing.

I found that the safety of doing [05/13] that early was questionable, but other than that, it was a pleasant read.