Re: [PATCH] rebase --skip: fix commit message clean up when skipping squash

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 7, 2023, 16:16 UTC
Message-ID: <xmqqzg32hlpd.fsf@gitster.g>
In-Reply-To: <b43a5b46-f391-bd9e-4bf2-bfeaa3548f3e@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 13 quoted lines

>> I am not sure if deviating from expect vs actual is such a good
>> idea.  It is not like use of two temporary files are transparent to
>> the caller of the new test helper---indeed, expect and actual are
>> likely to be used by the caller in tests that comes before or after
>> the ones that use test_commit_message, and by using a pair of files
>> that are different, the caller will now see two extra untracked
>> files left in the working tree.
>
> That's true, looking at test-lib-functions.sh it seems I unwittingly
> followed the example of test_cmp_config() which uses
> {actual,expect}.config when it calls test_cmp(). Anyway as this is in
> next I assume you're happy enough with the implementation as it
> stands.

You assumed too much ;-). The above is a bad move, but is minor enough and it is not a show-stopper. If you are aware of other bad examples, clean-up patches after the dust settles would be very much welcomed.

Thanks.