Re: [PATCH 1/4] t/lib-http: add serve-git.py

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 12, 2024, 21:51 UTC
Message-ID: <xmqqzfrpomn9.fsf@gitster.g>
In-Reply-To: <20240612115028.1169183-2-cmn@dwim.me>

Carlos Martín Nieto <cmn@dwim.me> writes:

Show 5 quoted lines

> This is a basic HTTP server that is able to serve Git content via
> calling out to the underlying git commands. This avoids relying on CGI
> which can add complexity when trying to replicate some behaviours, in
> particular when the bidirectional stream and its directions being open
> or closed are important.

You wrote it in the cover letter already, but it won't be available to "git log" readers.

Give a bit of explanation on the reason why we do this in the first place, in other words, what we are shipping an HTTP server with our source for, before introducing "this is a server".

E.g. "instead of relying on an overly complex Apache with CGI, add a simple HTTP server based on http.server class that offers THIS AND THAT BENEFIT FOR OUR PURPOSE to help testing" or something like that.