Re: [PATCH v3 2/3] reftable/stack: allow locking of outdated stacks
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 20, 2024, 18:10 UTC
- Message-ID
- <xmqqzfo2gprt.fsf@gitster.g>
- In-Reply-To
- <6130565498e51ce3228d6fe5bc5f0b83c0db9182.1726653185.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> int reftable_stack_new_addition(struct reftable_addition **dest, > - struct reftable_stack *st); > + struct reftable_stack *st, > + int flags);
We usually use "unsigned" for a flag word, i.e., a collection of flag bits.
Show 8 quoted lines
> @@ -1314,6 +1376,7 @@ int cmd_main(int argc UNUSED, const char *argv[] UNUSED) > TEST(t_reftable_stack_reload_with_missing_table(), "stack iteration with garbage tables"); > TEST(t_reftable_stack_tombstone(), "'tombstone' refs in stack"); > TEST(t_reftable_stack_transaction_api(), "update transaction to stack"); > + TEST(t_reftable_stack_transaction_with_reload(), "transaction with reload"); > TEST(t_reftable_stack_transaction_api_performs_auto_compaction(), "update transaction triggers auto-compaction"); > TEST(t_reftable_stack_update_index_check(), "update transactions with equal update indices"); > TEST(t_reftable_stack_uptodate(), "stack must be reloaded before ref update");
Looking good.