Re: [BUG/WIP PATCH] unit-tests: use clean test environment

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2025, 14:07 UTC
Message-ID: <xmqqzfi2xl5q.fsf@gitster.g>
In-Reply-To: <Z8WFcaEtMCD5C0EN@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 5 quoted lines

> Maybe. I guess for unit tests it's a lot less clear cut as most of the
> tests won't depend on such a controlled environment. So sanitizing the
> environment would be a good enough first step for me, and if we see
> demand for making specific information available to lots of tests we
> could still start to expose those at a later point.

Fair enough.

To put it another way, if you write a test and if it gets affected by externalities, perhaps you are testing a function that is at too high a level that is not a suitable target for unit tested?

I am thinking about the recent "make repo-config callable with repo==NULL outside a repository" topic, for example, and I suspect repo_config() is in a layer that is at a bit too high for suitable unit test target.

Thanks.