Re: [PATCH] Allocate msg only after fatal checks to avoid leaks

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2025, 20:37 UTC
Message-ID: <xmqqzfeb74yy.fsf@gitster.g>
In-Reply-To: <pull.1998.git.git.1749843142000.gitgitgadget@gmail.com>

"Alex via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 13 quoted lines

> -	if (type != OBJ_BLOB) {
> -		strbuf_release(&msg->buf);
> -		free(value);
> -		free(msg);
> -		die(_("cannot read note data from non-blob object '%s'."), arg);
> -	}
> +    if (type != OBJ_BLOB) {
> +        free(value);
> +        die(_("cannot read note data from non-blob object '%s'."), arg);
> +    }
> +
> +    msg = xmalloc(sizeof(*msg));
> +    strbuf_init(&msg->buf, 0);

ALl the new lines seem to be indented by four spaces. Check with Documantation/CodingGuidelines.

Also, Documantation/SubmittingPatches::[[real-name]] asks folks to use their real name as authorname. You prefer your purdue address, that is fine, but let's do something like

    From: Jinyao Guo <guo846@purdue.edu>
    Signed-off-by: Jinyao Guo <guo846@purdue.edu>