Re: [PATCH] build: tolerate use of _Generic from glibc 2.43 with Clang
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 11, 2026, 03:23 UTC
- Message-ID
- <xmqqzf26sk80.fsf@gitster.g>
- In-Reply-To
- <20260505-b4-pks-ci-tolerate-glibc-generic-v1-1-5786386fe512@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 8 quoted lines
> Instead, work around the issue by not using -std=gnu99 with Clang when > using the Makefile and by disabling warnings about C11 extensions when > using Meson. This isn't ideal, but we at least retain the ability to > detect the (mis-)use of features from newer standards with GCC. > > An alternative to this might be to simply bump the required C standard > to C11, which is 15 years old by now and should have support on most > platforms out there. But some more esoteric platforms may not have it.
Wouldn't the approach you took on the meson side to pass "-Wno-c11-extensions" be yet another alternative? I think that is what the other proposal (which was only for Makefile world and not for meson world) did, even though it may not have been a great implemenation to help only those who use config.mak.dev
<pull.2291.git.git.1778120192298.gitgitgadget@gmail.com>
We would need a patch to apply at lesat on v2.54.0 but possibly older tracks if we plan to keep them also buildable.
Thanks.