Re: [PATCH] stash: use named constant when parsing "--all"

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 5, 2026, 05:27 UTC
Message-ID: <xmqqzewsogxs.fsf@gitster.g>
In-Reply-To: <06b58ae0a1d81f4d1518eadecc3385072a72155a.1791108351.git.phillip.wood@dunelm.org.uk>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 13 quoted lines

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> The code that stashes all untracked files compares the value of the
> "include_untracked" variable to the constant "INCLUDE_ALL_FILES",
> however the option parsing code for "--all" uses a hard coded integer
> instead. Replace the integer with the named constant.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> ---
> -			    N_("include ignore files"), 2),
> +			    N_("include ignore files"), INCLUDE_ALL_FILES),
> -			    N_("include ignore files"), 2),
> +			    N_("include ignore files"), INCLUDE_ALL_FILES),

So obviously right.  I wish all patches were like this ;-).