Re: [PATCH] t0081: modernize the code testing whether a file exists

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 14, 2026, 21:47 UTC
Message-ID: <xmqqzewgosyw.fsf@gitster.g>
In-Reply-To: <CAPSxiM9-F-1XKvWeEnBk=_FyKyev5pfnid4fiN-OjLYLnCTWVw@mail.gmail.com>

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:

Show 8 quoted lines

>> From: Shashank <shashu8660@gmail.com>
>>
>> Replace the old-style shell `test -f` command with Git's modern
>> `test_path_is_file`.
>>
>> This instance was found using:
>> `git grep "test -[efd]" t/'
> This is not necessary, remove it.

Since many candidates are working on similar microprojects (which is fine) and making the same mistakes (which is expected), perhaps mentors should tell them to read the review exchanges on other candidates' patches and learn from them, instead of or in addition to giving the same advice repeatedly.