Re: [PATCH 00/13] SHA-1/SHA-256 interoperability, part 3: pack index v3
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 21, 2026, 19:01 UTC
- Message-ID
- <xmqqzew6naiw.fsf@gitster.g>
- In-Reply-To
- <20261021063245.2917625-1-christian.couder@gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
> My `Signed-off-by: ...` was added only to the changed patches.
Please read DCO again; it is fairly clear on what you need to do in cases like this:
b. The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or c. The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.b. covers the ones you changed. c. covers the ones you are relaying. You need to sign both kinds off.
Show 7 quoted lines
> - Patches 1 and 4 are adapted to `ps/odb-files-alternates`. There is > now a single `odb->source`, so `odb_map_oid()` and > `odb_write_oid_map()` just dispatch to it. The files backend checks > each of its object directories in turn (main directory first, then > alternates) and writes mappings into the main directory, like it > does for objects. The `read_alternates` callbacks are dropped, as > the topic removed them.
Thanks for rebasing these (and all others), and
> - Patches 7, 8, 11 and 12 now also add tests to t1016 for the > problems fixed in them, which were not covered before. They use a > new small `create_compat_repo()` helper introduced in patch 7.
adding tests and generally polishing them.