Re: What's cooking in git.git (Nov 2026, #01)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 4, 2026, 18:09 UTC
- Message-ID
- <xmqqzevo1nan.fsf@gitster.g>
- In-Reply-To
- <20261104064115.GD1543013@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> On Mon, Nov 02, 2026 at 06:31:14PM -0800, Junio C Hamano wrote: > >> * jk/test-env-quoting-fix (2026-10-30) 1 commit >> - t5702: be more resilient to env quoting >> >> Tests in 't5702' that grep the output of 'env' to check for the >> 'GIT_PROTOCOL' environment variable have been updated to explicitly >> echo the variable instead, making them resilient to quoting changes >> introduced in newer GNU coreutils. >> >> Will merge to 'next'? >> cf. <xmqqwlqytvg9.fsf@gitster.g> >> source: <20261031002550.GA626623@coredump.intra.peff.net> > > It sounds from the discussion in the thread that the coreutils behavior > has changed so that this becomes a non-issue. And I just double-checked > that the version in debian unstable now works without the patch. That > said, I think the code after the patch is more robust in general. IMHO > it's still worth doing.
Yes, I agree that your change to make the test immune to the way how variables and their values are quoted by "env" is a good thing.