Re: socket_perror() "bug"?
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 31, 2014, 20:50 UTC
- Message-ID
- <xmqqy4zq3xek.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <CACnwZYc2py4dxehg2=gnnPLxwJaRqXYTLQvC1O7YuoqAWsZ0Tg@mail.gmail.com>
Thiago Farina <tfransosi@gmail.com> writes:
Show 7 quoted lines
> In imap-send.c:socket_perror() we pass |func| as a parameter, which I > think it is the name of the function that "called" socket_perror, or > the name of the function which generated an error. > > But at line 184 and 187 it always assume it was SSL_connect. > > Should we instead call perror() and ssl_socket_error() with func?
Looks that way to me, at least from a cursory look.