git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rerere: fix for merge.conflictstyle

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 30, 2014, 14:04 UTC
Message-ID
<xmqqy4ymhq0l.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140430060835.GA21698@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> I could not reproduce the problem with a trivial case, and rerere
> specifically tries to handle the differences between "merge" and "diff3"
> styles by throwing away the base content between "|" and "=" lines.
> However, I wonder if it could still miss a match in some cases because
> the "merge" style uses XDL_MERGE_ZEALOUS, whereas diff3 bumps it
> down to XDL_MERGE_EAGER, which could lead to a slightly different
> preimage.
>
> If so, I think this points to a slightly more pervasive problem in
> "rerere", then: data recorded under one merge level might not be usable
> later (whether for "rerere forget" or for actually applying a
> resolution).
> ...
>
> So given all of the "hopefully rare" statements above and the complexity
> of the complete solution, it's probably not worth pursuing. In which
> case your patch seems like the best we can do. At least it covers the
> more common case when you have set merge.conflictstyle but _didn't_
> change it since the postimage was recorded.

Thanks for a fix, Felipe, and thanks for a more detailed discussion, Peff. I think I saw the exact same symptom in "forget" the other day, but was too busy to pursue it at that moment.

Previous: Felipe Contreras
Message 4 of 4 in “rerere: fix for merge.conflictstyle”
  1. rerere: fix for merge.conflictstyleFelipe Contreras, Apr 30, 2014
  2. Jeff KingApr 30, 2014
  3. Felipe ContrerasApr 30, 2014
  4. Junio C HamanoApr 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.