Re: [PATCH] git-imap-send: use libcurl for implementation

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 9, 2014, 17:45 UTC
Message-ID: <xmqqy4rkb74v.fsf@gitster.dls.corp.google.com>
In-Reply-To: <545FA3FA.10308@ramsay1.demon.co.uk>

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

Show 8 quoted lines

>> In order to suppress a sparse warning about "using sizeof on a
>> function", we use the same solution used in commit 9371322a6
>> ("sparse: suppress some "using sizeof on a function" warnings",
>> 06-10-2013) which solved exactly this problem for the other commands
>> using libcurl.
>
> Although it doesn't hurt, I don't think this 'problem' deserves
> so many (or any) inches in the commit message. ;-)

Use smaller line pitch, then? ;-) I am sure myself 6 months down the road as a "git show" reader of this patch would appreciate these five lines when I scratch my head looking at the Makefile changes.

Show 7 quoted lines

>> Signed-off-by: Bernhard Reiter <ockham@raz.or.at>
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>
> Since I didn't actually review this patch, or make any significant
> contribution to the code (it's not even enough to be copyright-able!),
> then this 'Signed-off-by:' should not be included. At *most* you might
> want to put a 'Helped-by:' _prior_ to your sign-off.

Yes, that is the appropriate thing to do, I would think.

Thanks.