Re: [RFC/PATCH 5/9] ref-filter: add option to match literal pattern
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 29, 2015, 18:20 UTC
- Message-ID
- <xmqqy4j29y0o.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1435232596-27466-5-git-send-email-karthik.188@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
> Since 'ref-filter' only has an option to match path names.
That is not a whole sentence ;-)
> Add an option for regular pattern matching.
> Mentored-by: Christian Couder <christian.couder@gmail.com> > Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr> > Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
Show 5 quoted lines
> - if (flag & REF_BAD_NAME) {
> - warning("ignoring ref with broken name %s", refname);
> - return 0;
> - }
> -Hmm, where did this check go in the new code? Or is it now OK not to warn or ignore, and if so why?
Show 10 quoted lines
> if (flag & REF_ISBROKEN) {
> warning("ignoring broken ref %s", refname);
> return 0;
> }
>
> - if (*filter->name_patterns && !match_name_as_path(filter->name_patterns, refname))
> + if (!filter_pattern_match(filter, refname))
> return 0;
>
> if (!match_points_at(&filter->points_at, oid->hash, refname))Show 11 quoted lines
> diff --git a/ref-filter.h b/ref-filter.h
> index 6b6fb96..a4809c8 100644
> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -54,7 +54,8 @@ struct ref_filter {
> } merge;
> struct commit *merge_commit;
>
> - unsigned int with_commit_tag_algo: 1;
> + unsigned int with_commit_tag_algo: 1,
> + match_as_path: 1;Lose SP on both sides of the colon, or have SP on both sides (same for the last patch in the previous series).