Re: [PATCHv4 3/3] submodule: implement `clone` as a builtin helper

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 1, 2015, 19:13 UTC
Message-ID: <xmqqy4gqq7fw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAPig+cRxQdquKZXdmpiZjj8JFB2wdCE4UcbW6qYUwvtZsVw=ug@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 6 quoted lines

> On Tue, Sep 1, 2015 at 2:24 PM, Stefan Beller <sbeller@google.com> wrote:
>> This converts implements the helper `module_clone`. This functionality is
>
> Mentioned previously[1]: "converts implements"?
>
> [1]: http://article.gmane.org/gmane.comp.version-control.git/276966

Stefan, perhaps another round of proofreading before sending would have helped.

I am neutral with asterisk around const myself. I think I saw this often spelled with SP on both sides, i.e.

	$ git grep ' \* const ' \*.c | wc -l
        121
        $ git grep ' \*const ' \*.c | wc -l
        45

Majority of the latter, when viewed without pipe to wc, tells me they are mostly borrowed code.

All the other comments from you on this patch makes sense to me.

Thanks.