Re: [PATCH v2 3/4] Add support for matching full refs in hideRefs

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 4, 2015, 19:09 UTC
Message-ID: <xmqqy4eda8fd.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqd1vqdc7c.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 21 quoted lines

> The semantics of "hideRefs" used to be that "refs can be hidden from
> ls-remote" (i.e. prevents fetching, avoids contaminating "--mirror")
> and "refs can be hidden from 'push'", but the objects being known
> tips of histories that are complete, they still participate in
> common ancestor discovery.  
>
>> diff --git a/Documentation/config.txt b/Documentation/config.txt
>> index 3da97a1..91ed6a5 100644
>> --- a/Documentation/config.txt
>> +++ b/Documentation/config.txt
>> @@ -2690,7 +2690,8 @@ the prefix `refs/heads/master` is specified in `transfer.hideRefs` and the
>>  current namespace is `foo`, then `refs/namespaces/foo/refs/heads/master` is
>>  omitted from the advertisements but `refs/heads/master` and
>>  `refs/namespaces/bar/refs/heads/master` are still advertised as so-called
>> -"have" lines.
>> +"have" lines. In order to match refs before stripping, add a `^` in front of
>> +the ref name. If you combine `!` and `^`, `!` must be specified first.
>
> I think the changes in the above two hunks prevent the hidden refs
> from participating in common ancestor discovery (which is probably a
> good thing), making the above description stale.

Ah, I was confused. The description only says "refs from outer namespaces are not advertised, but still participate the common ancestor discovery in the form of .have lines", and moving the location where ref-is-hidden is called in this patch does not affect that fact at all.

So this looks good as-is.

Thanks.