git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3] submodule: Port resolve_relative_url from shell to C

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 13, 2016, 16:58 UTC
Message-ID
<xmqqy4btpgbe.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<5695FFDA.9050409@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 12 quoted lines
> Am 13.01.2016 um 01:10 schrieb Stefan Beller:
>> Later on we want to deprecate the `git submodule init` command and make
>> it implicit in other submodule commands. As these other commands are
>> written in C already, we'd need the init functionality in C, too.
>> The `resolve_relative_url` function is a major part of that init
>> functionality, so start by porting this function to C.
>
> Maybe tone down the word "major" to "a large and non-trivial function"?
> Otherwise, the lack of proof for the claim is irritating. (As we saw,
> the savings with the port to C are not breath-taking. But we have to
> start somewhere.)
> ...

All good suggestions. Thanks for a low latency review. Very much appreciated.

Previous: Johannes Sixt
Message 4 of 4 in “[PATCHv2] submodule: Port resolve_relative_url from shell to C”
  1. Stefan BellerJan 12, 2016
  2. [PATCHv3] submodule: Port resolve_relative_url from shell to CStefan Beller, Jan 13, 2016
  3. Johannes SixtJan 13, 2016
  4. Junio C HamanoJan 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.