Re: [PATCHv3] submodule: Port resolve_relative_url from shell to C
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 13, 2016, 16:58 UTC
- Message-ID
- <xmqqy4btpgbe.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <5695FFDA.9050409@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 12 quoted lines
> Am 13.01.2016 um 01:10 schrieb Stefan Beller: >> Later on we want to deprecate the `git submodule init` command and make >> it implicit in other submodule commands. As these other commands are >> written in C already, we'd need the init functionality in C, too. >> The `resolve_relative_url` function is a major part of that init >> functionality, so start by porting this function to C. > > Maybe tone down the word "major" to "a large and non-trivial function"? > Otherwise, the lack of proof for the claim is irritating. (As we saw, > the savings with the port to C are not breath-taking. But we have to > start somewhere.) > ...
All good suggestions. Thanks for a low latency review. Very much appreciated.