Re: [PATCH/RFC v3] add a commit.verbose config variable

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2016, 21:46 UTC
Message-ID: <xmqqy49qc8ga.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAFZEwPP5_rBKH_=0pv_3PszLYtnznXeGJg1+yjwbiH0m_BqdZQ@mail.gmail.com>

Pranit Bauva <pranit.bauva@gmail.com> writes:

Show 10 quoted lines

> On Fri, Mar 11, 2016 at 3:04 AM, Junio C Hamano <gitster@pobox.com>
> wrote:
>> But doesn't this belong to git_commit_config(), not
>> git_STATUS_config()?  Should "commit.verbose" make output from "git
>> status" verbose?
>
> True. It should belong to git_commit_config(). My bad. But
> surprisingly this code works. I have no idea why. I will update the
> Patch and I have also finished writing test so I will include that
> also.

If that is surprising to you, that indicates that you only tested "commit" and not "status", I think. If you choose commit.verbose to apply only to "commit", but not "status", then your test should cover both commands, i.e. when the configuration is set to true, the default verbosity level for "git commit" should be raised, and the verbosity level for "git status" should not be--both must be verified in your test script.