Re: [PATCH] submodule helper: accept '.' for repositories with no submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 22, 2016, 22:50 UTC
Message-ID: <xmqqy49adt4p.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kYhK1dDQsxjRwhArXMi-0Gbd8ciYwdFnerT4fjvpthWCg@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> So for now I would send the performance regressing flip of
> IS_GITLINK and match_pathspec targeting 2.7 and then add a
> --unmatch-ok switch for 2.8 and later?

"git submodule $subcommand -- COPYIN\*" that detects that there is no submodule that match the pathspec and errors out, which is what the C rewrite does, is a new feature that was done by accident when we should have been doing a faithful translation.

I'd say bug-to-bug-compatible regression fix is appropriate for 2.8 and below; the "check ce-mode first and then pathspec match" should be done as a new feature after 2.8 final, and if --unmatch-ok is necessary to make the feature work better, that, too, should come in the same timeframe.