git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] http.h: Add debug callback and helper routine for implementing the GIT_TRACE_CURL environment variable in http.c

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 19, 2016, 18:00 UTC
Message-ID
<xmqqy4891nsv.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160419151044.27814-2-gitter.spiros@gmail.com>
Elia Pinto <gitter.spiros@gmail.com> writes:
Show 25 quoted lines
> Add the debug callback and helper routine prototype used by
> curl_easy_setopt CURLOPT_DEBUGFUNCTION in http.c
> for implementing the GIT_TRACE_CURL environment variable
>
>
> Helped-by: Torsten Bögershausen <tboegi@web.de>
> Helped-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Helped-by: Eric Sunshine <sunshine@sunshineco.com> 
> Helped-by: Jeff King <peff@peff.net>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
>  http.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/http.h b/http.h
> index 4ef4bbd..a2d10bc 100644
> --- a/http.h
> +++ b/http.h
> @@ -224,4 +224,10 @@ extern int finish_http_object_request(struct http_object_request *freq);
>  extern void abort_http_object_request(struct http_object_request *freq);
>  extern void release_http_object_request(struct http_object_request *freq);
>  
> +/* Debug callback and helper routine for curl_easy_setopt CURLOPT_DEBUGFUNCTION */
> +static struct trace_key trace_curl = TRACE_KEY_INIT(CURL);
This will be multiply instanciated in every *.c file that includes http.h?
Show 5 quoted lines
> +int curl_trace(CURL *handle, curl_infotype type, char *data, size_t size, void *userp);
> +void curl_dump(const char *text, unsigned char *ptr, size_t size, char nohex);
> +
> +
>  #endif /* HTTP_H */

In any case, you'd want to combine this with 2/4 and write a single log message for the combined change.

Previous: Elia PintoNext: Ramsay Jones
Message 3 of 11 in “[PATCHv2 0/4] Implements the GIT_TRACE_CURL environment variable”
  1. Elia PintoApr 19, 2016
  2. 1/4 http.h: Add debug callback and helper routine for implementing the GIT_TRACE_CURL environment variable in http.cElia Pinto, Apr 19, 2016
  3. Junio C HamanoApr 19, 2016
  4. Ramsay JonesApr 19, 2016
  5. Ramsay JonesApr 19, 2016
  6. 2/4 http.c: implements the GIT_TRACE_CURL environment variableElia Pinto, Apr 19, 2016
  7. Junio C HamanoApr 19, 2016
  8. Junio C HamanoApr 19, 2016
  9. 3/4 git.txt: document the new GIT_TRACE_CURL environment variableElia Pinto, Apr 19, 2016
  10. 4/4 imap-send.c: introduce the GIT_TRACE_CURL enviroment variableElia Pinto, Apr 19, 2016
  11. Junio C HamanoApr 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.