Re: [PATCH] submodule deinit: require '--all' instead of '.' for all submodules

From: Junio C Hamano <gitster@pobox.com>
Date: May 3, 2016, 22:28 UTC
Message-ID: <xmqqy47qkc87.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1462313499-6760-1-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 6 quoted lines

> I developed it on top of 
>     "submodule deinit test: fix broken && chain in subshell"
>     on top of 2a4c8c36a7f6, 2016-03-24, Merge branch
>     'sb/submodule-module-list-pathspec-fix'
> but I think this would rather go in as a new feature, not on top
> of a bugfix topic, so I think this could go on origin/master ?

I do not particularly view it as a new feature. The way the old message suggested did not work in a pathological corner case, but we wanted to keep the "force user to be explicit when doing mass destruction", and a fix we happened to chose requires addition of a new option--that would still look like a fix to me.

It is not like we are forbidding the use of "submodule deinit ." that used to work in a tree with at least one tracked path. With the change, a script that has such a command will continue to work, no?