Re: [RFC PATCH] completion: support excluding refs

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 24, 2016, 16:52 UTC
Message-ID: <xmqqy43mqfcp.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160824084152.2857-1-judge.packham@gmail.com>

Chris Packham <judge.packham@gmail.com> writes:

Show 15 quoted lines

> Allow completion of refs with a ^ prefix. This allows completion of
> commands like 'git log HEAD ^origin/master'.
> ...
> +			[[ "$cur" == ^* ]] && pfx="^"
>  			for i in HEAD FETCH_HEAD ORIG_HEAD MERGE_HEAD; do
> -				if [ -e "$dir/$i" ]; then echo $i; fi
> +				if [ -e "$dir/$i" ]; then echo $pfx$i; fi
>  			done
>  			format="refname:short"
>  			refs="refs/tags refs/heads refs/remotes"
>  			;;
>  		esac
> -		git --git-dir="$dir" for-each-ref --format="%($format)" \
> +		git --git-dir="$dir" for-each-ref --format="$pfx%($format)" \
>  			$refs

That looks like a reasonable approach to me (but I am no expert in this area myself).