Re: [PATCH] clean: use warning_errno() when appropriate

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2017, 21:53 UTC
Message-ID: <xmqqy3x9bvvm.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170213211051.vsnnrtcsvuvfcwyk@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> IOW, I think this may be a case where we should be optimizing for
> programmer time (fewer lines of code, and one less thing to worry about
> in the callers) versus squeezing out every instruction.

Fair enough.

Unless we do the save_errno dance in all the helper functions we commonly use to safely stash away errno as necessary and tell developers that they can depend on it, the code in the patch that began this discussion still needs its own saved_errno dance to be safe, though. I do not have a feeling that we are not there yet, even after we teach xmalloc() and its family to do so.