Re: [PATCH 1/2] fast-export: deletion action first

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2017, 05:33 UTC
Message-ID: <xmqqy3upuk4o.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170425044641.sx5uoql4oiug6iq7@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Anyway. I don't think Miguel's patch needs to solve all of the lingering
> rename cases. But I am curious whether it makes some rename cases worse,
> because the depth-sorting was kicking in before and making them work.

I agree with you on both counts, and I care more about the second sentence, not just "am curious", but "am worried". I am not sure that this patch is safe---it looked more like robbing peter to pay paul or the other way around. Fixing for one class of breakage without regressing is one thing and it is perfectly fine to leave some already broken case broken with such a fix. Claiming to fix one class and breaking other class that was happily working is quite different, and that is where my "Wait, we also allow renames?" comes from.