Re: [PATCH v3] run-command: add hint when a hook is ignored
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 10, 2017, 04:21 UTC
- Message-ID
- <xmqqy3ojpr9f.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <0102015ef0ba0273-ed29c030-7cdc-4535-a411-6cc443bd5f43-000000@eu-west-1.amazonses.com>
Damien Marié <damien@dam.io> writes:
> When an hook is present but the file is not set as executable then git will > ignore the hook. > For now this is silent which can be confusing.
Quite honestly, I do not particulary think this is confusing, and I expect that this change will irritate many people by forcing them to either set the advise config or move the ones that they deliberately left unexecutable by renaming them by adding ".disabled" at the end.
But these remedies are easy enough, so let's see how well it works by merging it to 'next' and cooking it there for a while.
I've spotted two issues during the last-minute scan; I'll squash the fixes in in the meantime (if you are not going to change anything other than these two, there is no need to resend corrected patches).
Show 11 quoted lines
> diff --git a/Documentation/config.txt b/Documentation/config.txt > index 1ac0ae6adb046..9abca499f725c 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -351,6 +351,9 @@ advice.*:: > addEmbeddedRepo:: > Advice on what to do when you've accidentally added one > git repo inside of another. > + ignoredHook:: > + Advice shown if an hook is ignored because the it's not > + set as executable.
s/the it's not/the hook is not/;
Show 5 quoted lines
> @@ -38,6 +39,7 @@ static struct {
> { "objectnamewarning", &advice_object_name_warning },
> { "rmhints", &advice_rm_hints },
> { "addembeddedrepo", &advice_add_embedded_repo },
> + { "ignoredhook", &advice_ignored_hook},s/ignored_hook/& /;